Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecations and Fix some Comments #392

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

luthermonson
Copy link
Contributor

📝 Description

What does this PR do and why is this change necessary?

  • Drops some things that are deprecated like ioutil, HostURL and strings.Title
  • Fixes some simple grammar/spelling in comments

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?
make testunit

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@luthermonson luthermonson requested a review from a team as a code owner October 5, 2023 03:59
@luthermonson luthermonson force-pushed the fix-deprecations branch 2 times, most recently from 26e34c3 to 11586b2 Compare October 5, 2023 08:55
@zliang-akamai zliang-akamai requested a review from a team October 5, 2023 19:07
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that all changes keep original functionality, LGTM!

@zliang-akamai zliang-akamai merged commit a7788a6 into linode:main Oct 6, 2023
3 checks passed
@luthermonson luthermonson deleted the fix-deprecations branch October 6, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants